image/tarexport: fix some minor linting issues #48467
Merged
vvoland merged 3 commits intomoby:masterfrom Sep 11, 2024
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Commit 9160b9f removed the platform from the descriptor, but this field was still used further in the code, and now always taking an empty platform. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Remove some intermediate variables that were only used in a single place. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Member
Author
|
I was actually looking at some of the error-handling in this package, but didn't finish that yet, so pushing these firsts 😅 |
vvoland
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image/tarexport: rename variables that shadowed imports
image/tarexport: saveSession.save: remove redundant Platform
Commit 9160b9f removed the platform from
the descriptor, but this field was still used further in the code, and now
always taking an empty platform.
image/tarexport: saveSession.save: inline variables
Remove some intermediate variables that were only used in a single place.