add more //go:build directives to prevent downgrading to go1.16#48434
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 9, 2024
Merged
add more //go:build directives to prevent downgrading to go1.16#48434thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
…g to go1.16 commit 2847c4b switched networkdb to use go-immutable-radix v2, which uses generics, but failed to add the go:build directives. # github.com/docker/docker/libnetwork/networkdb ../../libnetwork/networkdb/networkdb.go:47:19: type instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:259:33: type instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:269:25: function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:270:27: function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) Signed-off-by: Sebastiaan van Stijn <[email protected]>
…rading to go1.16 commit 77f2d90 introduced the slices import, which uses generics, but failed to add the go:build directives. # github.com/docker/docker/daemon/logger/loggerutils ../../daemon/logger/loggerutils/logfile.go:770:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Sep 9, 2024
laurazard
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnetwork/networkdb: add //go:build directives to prevent downgrading to go1.16
commit 2847c4b switched networkdb to use
go-immutable-radix v2, which uses generics, but failed to add the go:build
directives.
daemon/logger/loggerutils: add //go:build directives to prevent downgrading to go1.16
commit 77f2d90 introduced the slices import,
which uses generics, but failed to add the go:build directives.