hack/make/.binary: enable pie mode on windows/arm64#48421
hack/make/.binary: enable pie mode on windows/arm64#48421thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/packaging
kind/refactor
|
Actually; noticed that windows/arm64 now supports it, since golang/go@3732a17 (go1.20), so let me update |
pie-mode is supported for windows/arm64 since https://go.dev/cl/452415, which is part of go1.20. Also update link to Go source for pie-mode support to match the location for current versions of Go because the package was moved in https://go.dev/cl/438475. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
make_update_link
branch
from
463ced1 to
d000f12
Compare
thaJeztah
changed the title
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Reversing upstream's conditional makes this a little hard to verify for correctness, but that's not new here (and shouldn't block this PR IMO ❤️).
|
LOL so I really just stumbled on this; I went looking for some options we set, to compare with the equivalent scripts in the CLI. That made me land on Lines 99 to 102 in 55752bb And I wondered if that's still relevant (well, unlikely is, because "FreeBSD"); but code.google.com is deprecated ... and the link was broken, so I searched if we had other references to it...
So, living up to my Yak-shaving expectations again 😂😂😂 |
|
Let me bring this one in; well unlikely be able to build for windows on arm64 any time soon, but at least the code is now "correct" in what it excludes 😄 and having a current link doesn't hurt. |
2 participants
pie-mode is supported for windows/arm64 since https://go.dev/cl/452415 (golang/go@3732a17), which is part of go1.20. Also update link to Go source for pie-mode support to match the location for current versions of Go because the package was moved in https://go.dev/cl/438475 (golang/go@8bd803f).