Skip to content

Fix typos#48393

Merged
laurazard merged 1 commit intomoby:masterfrom
NathanBaulch:typos
Sep 6, 2024
Merged

Fix typos#48393
laurazard merged 1 commit intomoby:masterfrom
NathanBaulch:typos

Conversation

@NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Aug 27, 2024

Just thought I'd contribute some typo fixes I stumbled upon. Nothing controversial (hopefully), just 166 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • selectd (16)
  • sinds (10)
  • lenght (9)
  • wheter (7)
  • exepcted (5)
  • statisfy (5)
  • ambigous (5)
  • unintentially (4)
  • unwieldly (3)
  • chec (3)
  • addded (3)
  • inverval (3)
  • multipler (2)
  • sanitisation (2)
  • querries (2)
  • continer (2)
  • mounc (2)
  • delele (2)
  • enpoint (2)
  • persistance (2)

@NathanBaulch NathanBaulch requested a review from cpuguy83 as a code owner August 27, 2024 23:29
thaJeztah
thaJeztah requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

I only did a quick pass, but overall looks great! Left some quick comments, but viewed from my browsers, so maybe missed some 🥹😅

@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Aug 28, 2024

Awesome to get such a quick and positive response @thaJeztah - fixed them all! 🙏

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Aug 28, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Aug 28, 2024
NathanBaulch
NathanBaulch commented Aug 28, 2024
View reviewed changes
Copy link
Contributor Author

@NathanBaulch NathanBaulch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes done.
(not sure how to clear the "Changes requested" status")

@cpuguy83 cpuguy83 requested a review from thaJeztah August 30, 2024 22:07
laurazard
laurazard approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with a couple comments)

@laurazard
Copy link
Member

laurazard commented Sep 6, 2024

(not sure how to clear the "Changes requested" status")

@thaJeztah needs to approve to clear the prior "changes requested".

thaJeztah
thaJeztah approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! thanks for the ping; this one dropped of my radar 🙈

For dismissing the changes requested; I think only users with write-access can do so;

Screenshot 2024-09-06 at 12 28 47

changes LGTM though!

we may need to do a small follow-up because there's not a v1.47.yaml for the API docs

@laurazard
Copy link
Member

laurazard commented Sep 6, 2024

For dismissing the changes requested; I think only users with write-access can do so;

Oh, I didn't realize that was a thing one can do! 😅

@laurazard
Copy link
Member

laurazard commented Sep 6, 2024

we may need to do a small follow-up because there's not a v1.47.yaml for the API docs

There is now I think? #48422 was merged.

@NathanBaulch could you TAL/update docs/api/v1.47.yaml?

@thaJeztah
Copy link
Member

thaJeztah commented Sep 6, 2024

Arf s/not/now/ - thanks auto-correct!

@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Sep 6, 2024

Sure, what do I need to do with this file @laurazard? This is my first time contributing to this project.

@laurazard
Copy link
Member

laurazard commented Sep 6, 2024 •
edited
Loading

Ah - this file was added after you've opened your PR. Your PR makes changes to a lot of those docs/api/*.yaml files but not that one (because it wasn't there when you started this).

The best option would be for you to rebase your branch with the latest changes from master (if you're working in a CLI, git fetch upstream master && git rebase upstream/master (replace upstream with whatever you named this remote), and then apply your typo fixes to that file as well.

If that sounds complicated, I'm okay with us just merging this PR and then you could open a new PR fixing up that file. (I'm also happy to help with any of this if you have any questions!)

@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Sep 6, 2024

I'm comfortable rebasing, standby...

@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Sep 6, 2024

Done, and gave v1.47.yaml the once over too. Did you want me to squash my 3 commits into one?

@laurazard
Copy link
Member

laurazard commented Sep 6, 2024

Looks great! Yup, please squash (and remember to sign-off the squashed commit).

@NathanBaulch
Fix typos
59eba0a 
Signed-off-by: Nathan Baulch <[email protected]>
thaJeztah
thaJeztah approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@thaJeztah
Copy link
Member

thaJeztah commented Sep 6, 2024

And now, we should go look why the misspell linter (or other ones) didn't spot these 😂

@laurazard laurazard merged commit 96898c8 into moby:master Sep 6, 2024
@NathanBaulch NathanBaulch deleted the typos branch September 6, 2024 22:38
@laurazard laurazard mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@vvoland vvoland vvoland approved these changes

@coolljt0725 coolljt0725 coolljt0725 approved these changes

@laurazard laurazard laurazard approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83 cpuguy83 is a code owner

Assignees

No one assigned

Labels

kind/refactor PR's that refactor, or clean-up code process/cherry-picked status/2-code-review

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@NathanBaulch @laurazard @thaJeztah @vvoland @coolljt0725