man: create parent directories in install recipe#48388
Merged
tianon merged 1 commit intomoby:masterfrom Aug 29, 2024
Merged
Conversation
tianon
reviewed
Aug 28, 2024
| @@ -36,6 +36,7 @@ man%: | |||
| .PHONY: install | |||
| install: all | |||
| for sec in $(sections); do \ | |||
Member
There was a problem hiding this comment.
Oh, it occurs to me that we should probably include set -e here too because that's only the default in POSIX compliant mode, apparently? https://www.gnu.org/software/make/manual/html_node/Choosing-the-Shell.html
Member
There was a problem hiding this comment.
Oh! Yes I recall that indeed; I recall I had a PR once to consider explicitly enabling posix mode for that reason;
tianon
approved these changes
Aug 28, 2024
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM, although with a related note/suggestion 🙈
Support the use of `make install` in packaging scripts, where the $mandir tree might not exist under $DESTDIR. For portability, create the parent directories using a separate install command instead of relying on the non-portable `-D` flag. Set errexit so the install target fails if any install step fails. Signed-off-by: Cory Snider <[email protected]>
corhere
force-pushed
the
dockerd-manpage-install
branch
from
63090bf to
88b1186
Compare
tianon
approved these changes
Aug 29, 2024
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Support the use of
make installin packaging scripts, where the $mandir tree might not exist under $DESTDIR.- How I did it
For portability, create the parent directories using a separate install command instead of relying on the non-portable
-Dflag.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)