libnetwork: resolvconf: remove dependency on errdefs#48370
Merged
thaJeztah merged 2 commits intomoby:masterfrom Aug 26, 2024
Merged
libnetwork: resolvconf: remove dependency on errdefs#48370thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
It was only used in a single place, so we can remove the intermediate variable. Signed-off-by: Sebastiaan van Stijn <[email protected]>
the resolvconf package is imported in BuildKit, and this is the only location that used the errdefs package outside of the client. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/networking
akerouanton
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnetwork: resolvconf: remove var that shadowed import
It was only used in a single place, so we can remove the
intermediate variable.
libnetwork: resolvconf: remove dependency on errdefs
the resolvconf package is imported in BuildKit, and this is the only
location that used the errdefs package outside of the client.