Use environmental proxy when doing a ping to the remote repo#4836
Merged
vieux merged 2 commits intomoby:masterfrom Mar 28, 2014
Merged
Use environmental proxy when doing a ping to the remote repo#4836vieux merged 2 commits intomoby:masterfrom
vieux merged 2 commits intomoby:masterfrom
Conversation
rthomas
changed the title
Contributor
|
ping @shin- |
Contributor
|
Can you please sign their commits following these rules: https://github.com/dotcloud/docker/blob/master/CONTRIBUTING.md#sign-your-work Each commit in your PR must be signed in the following format: Please rebase and sign each commit. |
Contributor
Author
|
Rebased and updated commit message. |
|
Great to see there is already a pull request for this. It's been causing us pain. Thanks guys! |
Contributor
|
@rthomas travis is still failing because you need to gofmt your code. |
Contributor
Author
|
Updated PR with formatted code. |
Contributor
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
vieux
added a commit
that referenced
this pull request
Mar 28, 2014
Use environmental proxy when doing a ping to the remote repo
This was referenced Mar 28, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.