c8d/list: Don't require opts.ContainerCount for manifest containers#48345
Merged
vvoland merged 1 commit intomoby:masterfrom Aug 16, 2024
Merged
c8d/list: Don't require opts.ContainerCount for manifest containers#48345vvoland merged 1 commit intomoby:masterfrom
opts.ContainerCount for manifest containers#48345vvoland merged 1 commit intomoby:masterfrom
Conversation
The `GET /images/json` requires an optional `container-count` parameter which set the `Containers` property of in the ImageSummary to a number of containers using that image. This was also propagated to the new manifest list property which includes a list of all the container IDs that are using this specific image manifest. Disconnect the `ImageData.Containers` property from this option and always include it by default without an explicit opt-in. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
area/api
This was referenced Aug 16, 2024
Member
|
LOL, looks like GHA runners ran out of space. Hope it's not a change in the default size for those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container-countparameter #47501container-countparameter #47501The
GET /images/jsonrequires an optionalcontainer-countparameter which set theContainersproperty of in the ImageSummary to a number of containers using that image.This was also propagated to the new manifest list property which includes a list of all the container IDs that are using this specific image manifest.
Disconnect the
ImageData.Containersproperty from this option and always include it by default without an explicit opt-in.- What I did
- How I did it
- How to verify it
- Description for the changelog
#47526 wasn't released yet so no changelog needed.
- A picture of a cute animal (not mandatory but encouraged)