Makefile: Add BIND_GIT variable#48303
Merged
vvoland merged 1 commit intomoby:masterfrom Aug 8, 2024
Merged
Conversation
thaJeztah
reviewed
Aug 7, 2024
Defining BIND_GIT will bind mount the common .git directory into the dev container. This makes it possible to run some hack/* scripts which rely on `git` when running the container in a git worktree. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
makefile-bindgit
branch
from
1046630 to
8411ecb
Compare
thaJeztah
approved these changes
Aug 7, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
generally LGTM
I must say that we should have a look at all options we have, as the list is growing rapidly, and I wonder if we can simplify things somehow.
LOL, I initially was confused as well ("isn't BIND_DIR already mounting all the things?" but realised that doesn't work with worktree)
Member
|
I can /cc @tianon for extra eyes if we want to |
austinvazquez
approved these changes
Aug 7, 2024
tianon
approved these changes
Aug 7, 2024
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Agreed that this whole thing is pretty "byzantine" now but the use case here is pretty clear 👍
Member
|
Thanks @tianon ! Adding "Byzantine" to my list of pretty words to describe ugly things 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining BIND_GIT will also bind mount the common .git directory into the dev container.
This makes it possible to run some hack/* scripts which rely on
gitwhen running the container in a git worktree.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)