IPv6 only: macvlan and ipvlan drivers#48299
Merged
robmry merged 8 commits intomoby:masterfrom Sep 13, 2024
Merged
Conversation
robmry
added
kind/feature
akerouanton
reviewed
Aug 8, 2024
Member
akerouanton
left a comment
akerouanton
left a comment
There was a problem hiding this comment.
LGTM, but I'll wait for the other PR to be merged to add my green stamp.
robmry
force-pushed
the
v6only/macvlan_ipvlan
branch
2 times, most recently
from
7b02ce9 to
c169841
Compare
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
v6only/macvlan_ipvlan
branch
from
c169841 to
18071a0
Compare
Contributor
Author
|
Rebased (to get rid of the DNS commits), and updated the comment Cory commented on. |
An address can be assigned in the container (maybe by DHCP). DNS lookups work once there's an address and a route, before that, there's no source address for lookups made by the internal resolver from the container's network namespace. In this case, don't want to hook it up to docker_gwbridge, so disable it in joinInfo - this currently means no DNS entry for the container's name is set up in the internal DNS. (Even once the interface has a user-assigned address, there won't be an internal-DNS entry for the container until it's connected to a with-IPAM network as well.) Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
An address can be assigned in the container (maybe by DHCP). DNS lookups work once there's an address and a route, before that, there's no source address for lookups made by the internal resolver from the container's network namespace. In this case, don't want to hook it up to docker_gwbridge, so disable it in joinInfo - this currently means no DNS entry for the container's name is set up in the internal DNS. (Even once the interface has a user-assigned address, there won't be an internal-DNS entry for the container until it's connected to a with-IPAM network as well.) Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
v6only/macvlan_ipvlan
branch
from
18071a0 to
771377f
Compare
akerouanton
approved these changes
Sep 13, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Allow creation of macvlan/ipvlan networks with no IPv4 address, and with no IPv4 or IPv6 address.
- How I did it
For each driver:
docker_gwbridgefrom being created/connected if no address is assigned.- How to verify it
New tests.
With
--experimental...- Description for the changelog
- Allow creation of macvlan and ipvlan networks without IPv4 address assignment, and with no IP address assignment.