IPv6 only: gateway, IPAM and address configuration#48284
Merged
robmry merged 5 commits intomoby:masterfrom Aug 6, 2024
Merged
Conversation
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
robmry
added
kind/feature
robmry
requested review from
akerouanton and
corhere
and removed request for
corhere
akerouanton
reviewed
Aug 5, 2024
| }() | ||
|
|
||
| defer func() { | ||
| if err != nil { |
Member
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if retErr != nil { |
Contributor
Author
There was a problem hiding this comment.
So, unrelated to changes in this PR, you're suggesting refactoring this function to make it use a retErr - ok, I can do that ...
akerouanton
approved these changes
Aug 5, 2024
Member
akerouanton
left a comment
akerouanton
left a comment
There was a problem hiding this comment.
I'd prefer having ipamAllocate written in a more idiomatic way, but since the code isn't broken, my previous comment is only a minor nit and not a hard blocker.
Signed-off-by: Rob Murray <[email protected]>
corhere
approved these changes
Aug 5, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Top-level
libnetworkchanges for IPv6-only, apart from DNS (which is up-next!).- How I did it
Sandbox.needDefaultGWcheck for an IPv6 gateway.docker_gwbridgeisn't added for an IPv6-only network.enableIPv4in the tests that need it.ipv4 pool is emptybecause no IPv4 address pools are set up.enableIPv4.enableIPv4.- How to verify it
Updated tests still pass.
- Description for the changelog