Skip to content

api/swagger: fix x-nullable for SystemInfo.Containerd (api v1.46)#48275

Merged
vvoland merged 2 commits intomoby:masterfrom
thaJeztah:swagger_fix_nullable
Aug 9, 2024
Merged

api/swagger: fix x-nullable for SystemInfo.Containerd (api v1.46)#48275
vvoland merged 2 commits intomoby:masterfrom
thaJeztah:swagger_fix_nullable

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This field was added in 812f319, but it
looks like redoc doesn't like the field in this location, producing a
warning.

Rendering the docs (make swagger-docs) showed a warning:

Warning: Other properties are defined at the same level as $ref at
"#/definitions/SystemInfo/properties/Containerd". They are IGNORED
according to the JsonSchema spec

This field was added in 812f319, but it
looks like redoc doesn't like the field in this location, producing a
warning.

Rendering the docs (`make swagger-docs`) showed a warning:

> Warning: Other properties are defined at the same level as $ref at
> "#/definitions/SystemInfo/properties/Containerd". They are IGNORED
> according to the JsonSchema spec

Signed-off-by: Sebastiaan van Stijn <[email protected]>
This field was added in 812f319, but it
looks like redoc doesn't like the field in this location, producing a
warning.

Rendering the docs (`make swagger-docs`) showed a warning:

> Warning: Other properties are defined at the same level as $ref at
> "#/definitions/SystemInfo/properties/Containerd". They are IGNORED
> according to the JsonSchema spec

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Copy Markdown
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants