Skip to content

hack/make: suppress "not mounted" message#48272

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
kolyshkin:not-mounted
Jul 30, 2024
Merged

hack/make: suppress "not mounted" message#48272
AkihiroSuda merged 1 commit intomoby:masterfrom
kolyshkin:not-mounted

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Jul 30, 2024

The "not mounted" error from .integration-daemon-stop is not an error, so let's suppress that one (this is the only effect of -q option, at least according to its man page).

- What I did

Added -q to umount in hack/make/.integration-daemon-stop.

- How I did it

nvim

- How to verify it

ci

- A picture of a cute animal (not mandatory but encouraged)

@kolyshkin
hack/make: suppress "not mounted" message
3279b4f 
The "not mounted" error from .integration-daemon-stop is not an error,
so let's suppress that one (this is the only effect of -q option, at
least according to its man page).

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin requested a review from tianon as a code owner July 30, 2024 20:41
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Jul 30, 2024

This will remove the messages highlighted in bold below:

---> Making bundle: .integration-daemon-stop (in bundles/test-integration)
/go/src/github.com/docker/docker/hack/make/.integration-daemon-stop: line 13: wait: pid 62713 is not a child of this shell
warning: PID 62713 from bundles/test-integration/TestUsernsCommit/d8333e6ec8ebb/docker.pid had a nonzero exit code
umount: bundles/test-integration/TestUsernsCommit/d8333e6ec8ebb/root: not mounted.
/go/src/github.com/docker/docker/hack/make/.integration-daemon-stop: line 13: wait: pid 35909 is not a child of this shell
warning: PID 35909 from bundles/test-integration/TestAttachDisconnectLeak/df56255263fe0/docker.pid had a nonzero exit code
umount: bundles/test-integration/TestAttachDisconnectLeak/df56255263fe0/root: not mounted.
Leaving: AppArmorNo profiles have been unloaded.

@AkihiroSuda AkihiroSuda merged commit fe875a9 into moby:master Jul 30, 2024
@thaJeztah thaJeztah added status/4-merge area/testing kind/refactor PR's that refactor, or clean-up code labels Aug 1, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

No one assigned

Labels

area/testing kind/refactor PR's that refactor, or clean-up code status/4-merge

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @AkihiroSuda @thaJeztah