Skip to content

gha: set permissions to read-only by default#48262

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:gha_permissions
Jul 29, 2024
Merged

gha: set permissions to read-only by default#48262
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:gha_permissions

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jul 29, 2024

See if we can address some issues flagged by the OpenSSF scorecard; https://securityscorecards.dev/viewer/?uri=github.com/docker/docker

- Description for the changelog

Adjust GitHub actions permissions.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Jul 29, 2024
@thaJeztah thaJeztah self-assigned this Jul 29, 2024
@thaJeztah thaJeztah marked this pull request as ready for review July 29, 2024 12:18
@thaJeztah thaJeztah requested review from crazy-max and vvoland July 29, 2024 12:18
Copy link
Copy Markdown
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/.dco.yml Outdated

# TODO: hide reusable workflow from the UI. Tracked in https://github.com/community/community/discussions/12025

# Default to 'contents: read', which grants actions to # read commits.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Default to 'contents: read', which grants actions to # read commits.
# Default to 'contents: read', which grants actions to read commits.

Think you missed a # here while formatting the comments (and on a lot of the other files as well?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh 🙈 - fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants