libcontainerd/supervisor: remove remnants of adjusting oom-score#48252
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 29, 2024
Merged
libcontainerd/supervisor: remove remnants of adjusting oom-score#48252thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/daemon
thaJeztah
force-pushed
the
remove_oom_leftovers
branch
from
45987f3 to
423b243
Compare
vvoland
approved these changes
Jul 29, 2024
thaJeztah
force-pushed
the
remove_oom_leftovers
branch
from
423b243 to
5a96407
Compare
thaJeztah
force-pushed
the
remove_oom_leftovers
branch
from
5a96407 to
8b5d211
Compare
In docker versions before v24.0, the dockerd daemon allowed adjusting its own oom-score; in that case we would forward the configuration to containerd (when running as child process) for it to do the same. This feature was deprecated in 5a922dc, and removed in fb96b94, but some fields were left behind in the supervisor package. This patch removes the oomScore field and adjustOOMScore method from the remove type. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_oom_leftovers
branch
from
8b5d211 to
96762a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcontainerd/supervisor: remove remnants of adjusting oom-score
In docker versions before v24.0, the dockerd daemon allowed adjusting its own oom-score; in that case we would forward the configuration to containerd (when running as child process) for it to do the same.
This feature was deprecated in 5a922dc, and removed in fb96b94, but some fields were left behind in the supervisor package.
This patch removes the oomScore field and adjustOOMScore method from the remove type.