daemon: isPermissibleC8dRuntimeName: use local utility to reduce c8d deps#48251
Merged
vvoland merged 1 commit intomoby:masterfrom Jul 29, 2024
Merged
daemon: isPermissibleC8dRuntimeName: use local utility to reduce c8d deps#48251vvoland merged 1 commit intomoby:masterfrom
vvoland merged 1 commit intomoby:masterfrom
Conversation
…deps The `shim.BinaryName()` function used from containerd is part of the "github.com/containerd/containerd/runtime/v2/shim" packaqge, which comes with a large number of dependencies. This patch implements a local variant of the check so that we can remove the dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
1 task
thaJeztah
added
area/runtime
dmcgowan
approved these changes
Jul 27, 2024
vvoland
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shim.BinaryName()function used from containerd is part of the "github.com/containerd/containerd/runtime/v2/shim" packaqge, which comes with a large number of dependencies.This patch implements a local variant of the check so that we can remove the dependency.