Skip to content

libcontainerd/supervisor: un-embed and un-export containerd Config#48250

Draft
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:libcontainer_consolidate_defaults
Draft

libcontainerd/supervisor: un-embed and un-export containerd Config#48250
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:libcontainer_consolidate_defaults

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jul 26, 2024

Relates to

libcontainerd/supervisor: un-embed and un-export containerd Config

Make it slightly more clear that this struct is only mutated internally
or through DaemonOpt options.

@thaJeztah thaJeztah added area/runtime Runtime status/2-code-review area/daemon Core Engine kind/refactor PR's that refactor, or clean-up code labels Jul 26, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jul 26, 2024
@thaJeztah thaJeztah marked this pull request as draft July 26, 2024 21:31
@thaJeztah
Copy link
Copy Markdown
Member Author

Urgh.. think I missed a patch from the branch I had

@thaJeztah thaJeztah force-pushed the libcontainer_consolidate_defaults branch 3 times, most recently from ce4f9f4 to 104e733 Compare July 29, 2024 17:42
@thaJeztah thaJeztah force-pushed the libcontainer_consolidate_defaults branch 2 times, most recently from f3d6e5f to 7d4fc96 Compare August 19, 2024 11:04
@thaJeztah thaJeztah force-pushed the libcontainer_consolidate_defaults branch 3 times, most recently from 8c31e12 to cad7c62 Compare August 23, 2024 16:49
@thaJeztah thaJeztah changed the title libcontainerd/supervisor: consolidate platform-specific defaults and some cleanups libcontainerd/supervisor: un-embed and un-export containerd Config Aug 30, 2024
@thaJeztah thaJeztah force-pushed the libcontainer_consolidate_defaults branch from cad7c62 to 81f2bbd Compare August 30, 2024 13:47
@thaJeztah thaJeztah modified the milestones: 28.0.0, 29.0.0 Jan 17, 2025
Make it slightly more clear that this struct is only mutated internally
or through `DaemonOpt` options.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the libcontainer_consolidate_defaults branch from 81f2bbd to 50c66e9 Compare April 3, 2025 10:20
@thaJeztah thaJeztah modified the milestones: 29.0.0, 29.1.0 Jul 14, 2025
@vvoland vvoland modified the milestones: 29.1.0, v-future Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine area/runtime Runtime kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants