daemon: assorted cleanups and minor improvements#48244
Merged
thaJeztah merged 5 commits intomoby:masterfrom Jul 29, 2024
Merged
daemon: assorted cleanups and minor improvements#48244thaJeztah merged 5 commits intomoby:masterfrom
thaJeztah merged 5 commits intomoby:masterfrom
Conversation
The same code was used both on Linux and Windows; move it to a platform- agnostic file so that both can use this function, which contains GoDoc describing the functionality. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use a more distinct name, so that local variables can use it. While at it, also added GoDoc to describe its functionality. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The cleanups var collided with the cleanups import; rename it to use the same name as is used in the Windows implementation. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
These errors were unhandled; log them (at debug level for now). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/daemon
vvoland
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon: move sortMounts to a platform-agnostic file
The same code was used both on Linux and Windows; move it to a platform-
agnostic file so that both can use this function, which contains GoDoc
describing the functionality.
daemon: rename "mounts" type to reduce shadowing
Use a more distinct name, so that local variables can use it. While
at it, also added GoDoc to describe its functionality.
daemon: setupMounts: rename var that shadowed import
The cleanups var collided with the cleanups import; rename it to use
the same name as is used in the Windows implementation.
daemon: openContainerFS: rename output var
daemon: openContainerFS: log cleanup errors
These errors were unhandled; log them (at debug level for now).