Skip to content

[27.1 backport] migrate to github.com/moby/sys/user/userns#48238

Merged
vvoland merged 2 commits intomoby:27.0from
thaJeztah:27.1_backport_migrate_userns
Jul 26, 2024
Merged

[27.1 backport] migrate to github.com/moby/sys/user/userns#48238
vvoland merged 2 commits intomoby:27.0from
thaJeztah:27.1_backport_migrate_userns

Conversation

@thaJeztah
Copy link
Member

The userns package in libcontainer was integrated into the moby/sys/user module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends on runc/libcontainer, or on containerd, both of which have a complex dependency tree. This patch is part of a series of patches to unify the implementations, and to migrate toward that implementation to simplify the dependency tree.

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/sys@user/v0.1.0...user/v0.2.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 91dfc32)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The userns package in libcontainer was integrated into the moby/sys/user
module at commit [3778ae603c706494fd1e2c2faf83b406e38d687d][1].

The userns package is used in many places, and currently either depends
on runc/libcontainer, or on containerd, both of which have a complex
dependency tree. This patch is part of a series of patches to unify the
implementations, and to migrate toward that implementation to simplify
the dependency tree.

[1]: opencontainers/runc@3778ae6

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 2ce811e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jul 25, 2024
@thaJeztah thaJeztah added this to the 27.1.2 milestone Jul 25, 2024
@thaJeztah thaJeztah requested a review from cpuguy83 as a code owner July 25, 2024 12:16
@thaJeztah thaJeztah self-assigned this Jul 25, 2024
@AkihiroSuda AkihiroSuda changed the title [27.1 backport] migrate to github.com/moby/sys/usern [27.1 backport] migrate to github.com/moby/sys/userns Jul 25, 2024
@AkihiroSuda AkihiroSuda changed the title [27.1 backport] migrate to github.com/moby/sys/userns [27.1 backport] migrate to github.com/moby/sys/user/userns Jul 25, 2024
@vvoland vvoland merged commit 741e23b into moby:27.0 Jul 26, 2024
@thaJeztah thaJeztah deleted the 27.1_backport_migrate_userns branch July 26, 2024 13:11
@thaJeztah
Copy link
Member Author

⚠️ after further discussion, we decided to move this package to a separate module instead of as part of the moby/sys/user module; we should get that change in before tagging a new release;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

4 participants