vendor: github.com/gofrs/flock v0.12.1#48234
Merged
AkihiroSuda merged 2 commits intomoby:masterfrom Jul 25, 2024
Merged
Conversation
full diff: golang/sys@v0.21.0...v0.22.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
- fix: missing read-write flag in reopenFDOnError fixes a regression that could result in a `ERROR: bad file descriptor`. gofrs/flock@b659e1e introduced a regression where `f.flag` would not be in read-write mode [1] but read-only [2] which breaks people using NFS protocol. [1]: gofrs/flock@b659e1e#diff-87c2c4fe0fb43f4b38b4bee45c1b54cfb694c61e311f93b369caa44f6c1323ffR192 [2]: gofrs/flock@b659e1e#diff-22145325dded38eb5288ed3321a113d8260ccc70747ee04d4551bfd2fba975fdR69 full diff: gofrs/flock@v0.12.0...v0.12.1 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/bugfix
austinvazquez
approved these changes
Jul 25, 2024
AkihiroSuda
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: golang.org/x/sys v0.22.0
full diff: golang/sys@v0.21.0...v0.22.0
vendor: github.com/gofrs/flock v0.12.1
fixes a regression that could result in a
ERROR: bad file descriptor.gofrs/flock@b659e1e
introduced a regression where
f.flagwould not be in read-write mode1 but read-only 2 which breaks people using NFS protocol.
full diff: gofrs/flock@v0.12.0...v0.12.1
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)