Clean up networks in 'integration/network' tests#48217
Conversation
Makes TestDaemonDefaultNetworkPools re-runnable, and stops the accumulation of bridges from the others. Signed-off-by: Rob Murray <[email protected]>
|
oh! I recall I had a PR trying to do something similar, but I never got that to work; just in case it's useful, you could have a peek at it (if there's bit you could either use, or if there's other tests that should get the same treatment); |
Right, yes - same area ... I was mostly interested in tidying up the extra bridges, particularly for But, the changes also make sure I don't think modified default pool will necessarily be used in most of the tests, they don't delete |
|
I'll merge this ... there's undoubtedly more to do, but this is progress. |
Oh! Yes, for sure! Sorry, thought I replied 🙈 |
- What I did
Clean up networks in 'integration/network' tests
Makes
TestDaemonDefaultNetworkPoolsre-runnable, and stops the accumulation of bridges from the others.- How I did it
- How to verify it
Three consecutive runs of
TEST_INTEGRATION_DIR=./integration/network ./hack/make.sh test-integrationpassed, and didn't leave behind anybr-blahbridges.