dockerd-rootless-setuptool.sh: move RootlessKit smoke test#48216
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 24, 2024
Merged
dockerd-rootless-setuptool.sh: move RootlessKit smoke test#48216thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
`dockerd-rootless-setuptool.sh check` now skips the smoke test for running RootlessKit. Fix docker/docker-install issue 417 Signed-off-by: Akihiro Suda <[email protected]>
vvoland
approved these changes
Jul 24, 2024
thaJeztah
approved these changes
Jul 24, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
oh! I thought I already LGTM'd
well...
LGTM 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix docker/docker-install#417
- How I did it
dockerd-rootless-setuptool.sh checknow skips the smoke test for running RootlessKit.- How to verify it
dockerd-rootless-setuptool.sh check- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐧