contrib/check-config.sh: remove special case for userns on CentOS/RHEL 7#48212
Merged
tianon merged 1 commit intomoby:masterfrom Jul 23, 2024
Merged
contrib/check-config.sh: remove special case for userns on CentOS/RHEL 7#48212tianon merged 1 commit intomoby:masterfrom
tianon merged 1 commit intomoby:masterfrom
Conversation
This check was added in 2355151 to handle non-standard behavior in CentOS/RHEL 7; > Add check for RHEL7/CentOS7 experimental userns disabled > > Add a check in `check-config.sh` to see if we are running on a RHEL7 or > CentOS7 system, which may report that CONFIG_USERNS is OK/enabled, but > user namespaces still won't work because of the experimental feature > flag added by Redhat. > > This will add a warning if it is actually disabled and notes what has to > be added to the grub/boot command line to enable it. Now that CentOS/RHEL 7 reached EOL, we can remove this special case. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/security/userns
area/contrib
kind/refactor
Member
Author
|
This one's for you @tianon 🔥 🔥 🔥 🔥 #20643 (comment) 
|
AkihiroSuda
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contrib/check-config.sh: remove special case for userns on CentOS/RHEL 7
This check was added in 2355151 to handle non-standard behavior in CentOS/RHEL 7;
Now that CentOS/RHEL 7 reached EOL, we can remove this special case.
- A picture of a cute animal (not mandatory but encouraged)