daemon: remove setMayDetachMounts (set may_detach_mounts=1 on startup)#48210
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 29, 2024
Merged
daemon: remove setMayDetachMounts (set may_detach_mounts=1 on startup)#48210thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This function was added in 83c2152 to automatically set `/proc/sys/fs/may_detach_mounts=1` on startup. This is a kernel config available in RHEL7.4 based kernels that enables mountpoint removal where the mountpoint exists in other namespaces. This setting is the default, and non-configurable, on upstream kernels since 3.15. As this option was only supported in RHEL 7.x systems, which reached EOL, we can remove this code, as it's not doing anything on current kernels. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/daemon
cpuguy83
approved these changes
Jul 25, 2024
vvoland
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
may_detach_mounts=1on startup #34886This function was added in 83c2152 to automatically set
/proc/sys/fs/may_detach_mounts=1on startup.This is a kernel config available in RHEL7.4 based kernels that enables mountpoint removal where the mountpoint exists in other namespaces. This setting is the default, and non-configurable, on upstream kernels since 3.15.
As this option was only supported in RHEL 7.x systems, which reached EOL, we can remove this code, as it's not doing anything on current kernels.
- A picture of a cute animal (not mandatory but encouraged)