gha: check-pr-branch: fix branch check regression#48194
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 19, 2024
Merged
gha: check-pr-branch: fix branch check regression#48194thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This check was updated in f460110, but introduced some bugs; - the regular expressions were meant to define a capturing group, but the braces (`(`, `)`) were escaped (they previously were used by `sed`, which requires different escaping), so no value was captured. - the check itself was not updated to use the resulting `$target_branch` env-var, so was comparing against the `$GITHUB_BASE_REF` (which is the branch name before stripping minor versions). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/bugfix
vvoland
approved these changes
Jul 19, 2024
Member
Author
|
Check is green (and green on the backport); I'll merge this one, as we don't need the rest of CI to complete 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check was updated in f460110, but introduced some bugs;
(,)) were escaped (they previously were used bysed, which requires different escaping), so no value was captured.$target_branchenv-var, so was comparing against the$GITHUB_BASE_REF(which is the branch name before stripping minor versions).