vendor: github.com/containerd/containerd v1.7.20#48188
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 19, 2024
Merged
Conversation
full diff: containerd/containerd@v1.7.19...v1.7.20 Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Jul 19, 2024
thaJeztah
commented
Jul 19, 2024
Comment on lines
+958
to
+962
| if len(caps) == 0 { | ||
| s.Process.Capabilities.Inheritable = nil | ||
| } else if len(s.Process.Capabilities.Inheritable) > 0 { | ||
| filterCaps(&s.Process.Capabilities.Inheritable, caps) | ||
| } |
Member
Author
There was a problem hiding this comment.
FWIW; not (yet) back porting this bump to v27.1; I need to get my head around some of the changes here around capabilities (I know they were a bit of a footgun in the past, and I wanted to double check those changes).
Member
Author
I'll add cherry-pick labels though, so that we can include the bump in a patch release after we double-checked the changes (also to check if we need similar changes in the moby code) |
Member
Author
thaJeztah
added
process/cherry-picked
and removed
process/cherry-pick
process/cherry-pick/27.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: containerd/containerd@v1.7.19...v1.7.20
- A picture of a cute animal (not mandatory but encouraged)