Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
3 times, most recently
from
c3979ae to
4c1423f
Compare
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
2 times, most recently
from
0e80c53 to
97ba1b1
Compare
1 task
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
from
97ba1b1 to
812ad60
Compare
AkihiroSuda
changed the title
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
3 times, most recently
from
9a19025 to
5a7dc3b
Compare
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
2 times, most recently
from
0388d1a to
9537b5a
Compare
Member
Author
|
@thaJeztah Can we merge this? 🙏 |
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
3 times, most recently
from
a6923c3 to
6747bbb
Compare
tonistiigi
approved these changes
Sep 10, 2024
rootless-containers/rootlesskit@v2.0.2...v2.3.1 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
rootlesskit-2.2.0
branch
from
6747bbb to
43036f3
Compare
thaJeztah
approved these changes
Sep 11, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
whoops; I thought I submitted my review, but looks like it was still pending 🙈
LGTM
I left a comment; happy to hear your thoughts on that idea!
| github.com/pkg/errors v0.9.1 | ||
| github.com/prometheus/client_golang v1.17.0 | ||
| github.com/rootless-containers/rootlesskit/v2 v2.0.2 | ||
| github.com/rootless-containers/rootlesskit/v2 v2.3.1 |
Member
There was a problem hiding this comment.
Hm... so it only occurs to me now that there's no changes in vendored files; we only consume the rootlesskit client, and it looks like there were no changes there.
Definitely not a blocker for "master", but starting to wonder if it would make sense to make the API (and client) a separate module; it looks like it has no external dependencies (only stdlib), but because it's part of the main module will still cause all other dependencies to be updated;
git grep -E '("github.com/|"golang.org/)' ./vendor/github.com/rootless-containers/rootlesskit/
vendor/github.com/rootless-containers/rootlesskit/v2/pkg/api/client/client.go: "github.com/rootless-containers/rootlesskit/v2/pkg/api"
vendor/github.com/rootless-containers/rootlesskit/v2/pkg/api/client/client.go: "github.com/rootless-containers/rootlesskit/v2/pkg/httputil"
vendor/github.com/rootless-containers/rootlesskit/v2/pkg/api/client/client.go: "github.com/rootless-containers/rootlesskit/v2/pkg/port"
vendor/github.com/rootless-containers/rootlesskit/v2/pkg/port/port.go: "github.com/rootless-containers/rootlesskit/v2/pkg/api"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rootless-containers/rootlesskit@v2.0.2...v2.3.1
Depends on:
Fix #48257 (for pasta, via rootless-containers/rootlesskit#458)