rm regexp use#48169
Merged
vvoland merged 3 commits intomoby:masterfrom Jul 17, 2024
Merged
Conversation
Replace the regexp checking ID validity with a function. The benefits are: - function is faster (up to 10x faster with less allocations); - no init overhead to compile the regexp; Add a test case. Signed-off-by: Kir Kolyshkin <[email protected]>
Replace the regexp checking ID validity with a for loop. The benefits are: - faster (up to 10x faster with less allocations); - no init overhead to compile the regexp. Signed-off-by: Kir Kolyshkin <[email protected]>
Replace the regexp check with a function. Keep the use of regexp.QuoteMeta. Signed-off-by: Kir Kolyshkin <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
vvoland
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Replaced the regexp checking ID validity with a function. The benefits are:
- How I did it
- How to verify it
Test case is added (for the first commit only, others are identical).