libnetwork/networkdb: switch to go-immutable-radix v2#48157
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 31, 2024
Merged
libnetwork/networkdb: switch to go-immutable-radix v2#48157thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/networking
corhere
reviewed
Jul 11, 2024
Comment on lines
+347
to
+349
| if v == nil { | ||
| return nil, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Why is this check needed with v2 but not with v1?
Member
Author
There was a problem hiding this comment.
Good question; maybe it was needed as well; there's a nil-check two lines up, and my IDE was flagging it as "could be nil"; honestly not sure it there's such a chance
Contributor
There was a problem hiding this comment.
There is at least one other place which assumes that (*NetworkDB).getEntry() error = nil implies that the returned *entry is not nil.
moby/libnetwork/networkdb/delegate.go
Lines 171 to 179 in c287997
I am pretty sure that it is an invariant. An incomplete audit of the NetworkDB code suggests that to be the case.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
libnetwork_immutable_radix_v2
branch
from
4469c66 to
2847c4b
Compare
Member
Author
|
@corhere updated; I removed the |
corhere
approved these changes
Jul 29, 2024
vvoland
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)