Fix API version in TestSetInterfaceSysctl#48156
Merged
robmry merged 1 commit intomoby:masterfrom Jul 11, 2024
Merged
Conversation
The test checks that it's possible to set a per-interface sysctl using '--sysctl' - but, after API v1.46, it's not (and driver option 'com.docker.network.endpoint.sysctls' must be used instead). Test added in commit fde80fe Per-interface sysctls added, with API changes, in commit 0071832 Signed-off-by: Rob Murray <[email protected]>
robmry
added
area/networking
akerouanton
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix API version in TestSetInterfaceSysctl
The test checks that it's possible to set a per-interface sysctl using '--sysctl' - but, after API v1.46, it's not (and driver option 'com.docker.network.endpoint.sysctls' must be used instead).
- How I did it
Use API
1.46in the test.- How to verify it
Run the test when the default API has been bumped to
1.47.- Description for the changelog