Skip to content

daemon/graphdriver: remove Capabilities, CapabilityDriver#48143

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:graphdriver_remove_capabilities
Jul 15, 2024
Merged

daemon/graphdriver: remove Capabilities, CapabilityDriver#48143
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:graphdriver_remove_capabilities

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

daemon/graphdriver: deprecate Capabilities, CapabilityDriver

Capabilities were implemented in aa96c31, as part of work on an external graphdriver-plugin. Given that none of the builtin graphdrivers use this option, and support for graphdriver- plugins has been removed in 555dac5, we can remove this functionality.

This patch:

  • removes the CapabilityDriver interface, which has no implementations
  • removes the Capabilities type
  • layer: remove layerStore.useTarSplit. This field was previously set through the driver's Capabilities, but always enabled for the builtin graphdrivers,

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Capabilities were implemented in aa96c31,
as part of work on an external graphdriver-plugin. Given that none of
the builtin graphdrivers use this option, and support for graphdriver-
plugins has been removed in 555dac5,
we can remove this functionality.

This patch:

- removes the CapabilityDriver interface, which has no implementations
- removes the Capabilities type
- layer: remove layerStore.useTarSplit. This field was previously set
  through the driver's Capabilities, but always enabled for the builtin
  graphdrivers,

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added area/storage Image Storage status/2-code-review area/daemon Core Engine kind/refactor PR's that refactor, or clean-up code labels Jul 8, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jul 8, 2024
@thaJeztah thaJeztah self-assigned this Jul 8, 2024
@thaJeztah thaJeztah requested a review from cpuguy83 July 15, 2024 14:34
@thaJeztah thaJeztah merged commit fb5acc4 into moby:master Jul 15, 2024
@thaJeztah thaJeztah deleted the graphdriver_remove_capabilities branch July 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine area/storage Image Storage kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants