Remove IPv6 bridge RouteAdd() that always fails#48135
Merged
akerouanton merged 1 commit intomoby:masterfrom Jul 5, 2024
Merged
Remove IPv6 bridge RouteAdd() that always fails#48135akerouanton merged 1 commit intomoby:masterfrom
akerouanton merged 1 commit intomoby:masterfrom
Conversation
The netlink.RouteAdd in setupBridgeIPv6 always failed, because the bridge is always 'down' when it's called. Signed-off-by: Rob Murray <[email protected]>
robmry
added
area/networking
corhere
approved these changes
Jul 5, 2024
akerouanton
approved these changes
Jul 5, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The netlink.RouteAdd in setupBridgeIPv6 always fails, because the bridge is always 'down' when it's called.
- How I did it
Deleted it.
- How to verify it
There's no log entry about the failure any more.
A
--ipv6bridge still has an IPv6 route. (Just to check - I deleted the bridge's IPv6 route, bounced dockerd, and checked that the route came back.)- Description for the changelog