Skip to content

api/types: remove aliases for deprecated types#48107

Merged
thaJeztah merged 25 commits intomoby:masterfrom
thaJeztah:remove_deprecated_api_types
Jul 2, 2024
Merged

api/types: remove aliases for deprecated types#48107
thaJeztah merged 25 commits intomoby:masterfrom
thaJeztah:remove_deprecated_api_types

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jul 1, 2024

relates to:

api/types: remove deprecated ImagesPruneReport

It moved to api/types/image in ecb24af.
This patch removes the temporary alias.

api/types: remove deprecated VolumesPruneReport

It moved to api/types/volume in 162ef4f.
This patch removes the temporary alias.

api/types: remove deprecated NetworkCreateRequest

It moved to api/types/network.CreateRequest in 162ef4f.
This patch removes the temporary alias.

api/types: remove deprecated NetworkCreate

It moved to api/types/network.CreateOptions in 162ef4f.
This patch removes the temporary alias.

api/types: remove deprecated NetworkListOptions

It moved to api/types/network.ListOptions in f78dac3.
This patch removes the temporary alias.

api/types: remove deprecated NetworkCreateResponse

It moved to api/types/network.CreateResponse in 89624e0.
This patch removes the temporary alias.

api/types: remove deprecated NetworkCreateResponse

It moved to api/types/network.CreateResponse in 89624e0.
This patch removes the temporary alias.

api/types: remove deprecated NetworkInspectOptions

It moved to api/types/network.InspectOptions in 5bea0c3.
This patch removes the temporary alias.

api/types: remove deprecated NetworkConnect

It moved to api/types/network.ConnectOptions in 245d121.
This patch removes the temporary alias.

api/types: remove deprecated NetworkDisconnect

It moved to api/types/network.DisconnectOptions in 245d121.
This patch removes the temporary alias.

api/types: remove deprecated EndpointResource

It moved to api/types/network.EndpointResource in 68bf0e7.
This patch removes the temporary alias.

api/types: remove deprecated NetworkResource

It's replaced by api/types/network.Inspect and api/types/network.Summary in
68bf0e7. This patch removes the temporary alias.

api/types: remove deprecated NetworksPruneReport

It moved to api/types/network.PruneReport in e5f9484.
This patch removes the temporary alias.

api/types: remove deprecated ExecConfig

It moved to api/types/container.ExecOptions in cd76e3e.
This patch removes the temporary alias.

api/types: remove deprecated ExecStartCheck

It's replaced by api/types/container.ExecStartOptions and ExecAttachOptions
in cd76e3e. This patch removes the temporary
alias.

api/types: remove deprecated ContainerExecInspect

It moved to api/types/container.ExecInspect in 5b27e71.
This patch removes the temporary alias.

api/types: remove deprecated ContainersPruneReport

It moved to api/types/container.PruneReport in db2f1ac.
This patch removes the temporary alias.

api/types: remove deprecated ContainerPathStat

It moved to api/types/container.PathStat in 47d7c9e.
This patch removes the temporary alias.

api/types: remove deprecated CopyToContainerOptions

It moved to api/types/container.CopyToContainerOptions in fd1d8f3.
This patch removes the temporary alias.

api/types: remove deprecated ContainerStats

It moved to api/types/container.StatsResponseReader in 17c3269.
This patch removes the temporary alias.

api/types: remove deprecated container stats types

These types were moved to api/types/container in 0a4277a.

This removes the temporary aliases for:

  • ThrottlingData
  • CPUUsage
  • CPUStats
  • MemoryStats
  • BlkioStatEntry
  • BlkioStats
  • StorageStats
  • NetworkStats
  • PidsStats
  • Stats
  • StatsJSON (moved/renamed to api/types/container.StatsResponse)

api/types: remove deprecated EventsOptions

It moved to api/types/events.ListOptions in b5f15bc.
This patch removes the temporary alias.

api/types: remove deprecated ImageSearchOptions

It moved to api/types/registry.SearchOptions in f6cc76c.
This patch removes the temporary alias.

api/types: remove deprecated ImageSearchOptions

It moved to api/types/registry.SearchOptions in f6cc76c.
This patch removes the temporary alias.

api/types: remove deprecated ImageImportSource

It moved to api/types/image.ImportSource in eb675cc.
This patch removes the temporary alias.

api/types: remove deprecated ImageLoadResponse

It moved to api/types/image.LoadResponse in 6c2934f.
This patch removes the temporary alias.

api/types: remove deprecated ContainerNode, ContainerJSONBase.Node

It was moved and deprecated in 1fc9236
(4587688 for v27.0). This patch removes the
temporary alias and removes the relocated api/types/container.ContainerNode
as well as the Node field on the api/types/container.Base struct.

- Description for the changelog

api/types: Remove deprecated aliases:
- ImagesPruneReport
- VolumesPruneReport
- NetworkCreateRequest
- NetworkCreate
- NetworkListOptions
- NetworkCreateResponse
- NetworkCreateResponse
- NetworkInspectOptions
- NetworkConnect
- NetworkDisconnect
- EndpointResource
- NetworkResource
- NetworksPruneReport
- ExecConfig
- ExecStartCheck
- ContainerExecInspect
- ContainersPruneReport
- ContainerPathStat
- CopyToContainerOptions
- ContainerStats
- ImageSearchOptions
- ImageSearchOptions
- ImageImportSource
- ImageLoadResponse
- ContainerNode

api/types: Remove deprecated `container.ContainerNode` and `ContainerJSONBase.Node` field.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Jul 1, 2024
@thaJeztah thaJeztah self-assigned this Jul 1, 2024
@thaJeztah thaJeztah added the kind/refactor PR's that refactor, or clean-up code label Jul 1, 2024
thaJeztah added 22 commits July 2, 2024 14:19
It moved to api/types/image in ecb24af.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/volume in 162ef4f.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.CreateRequest in 162ef4f.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.CreateOptions in 162ef4f.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.ListOptions in f78dac3.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.CreateResponse in 89624e0.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.InspectOptions in 5bea0c3.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.ConnectOptions in 245d121.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.DisconnectOptions in 245d121.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.EndpointResource in 68bf0e7.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's replaced by api/types/network.Inspect and api/types/network.Summary in
68bf0e7. This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/network.PruneReport in e5f9484.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.ExecOptions in cd76e3e.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's replaced by api/types/container.ExecStartOptions and ExecAttachOptions
in cd76e3e. This patch removes the temporary
alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.ExecInspect in 5b27e71.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.PruneReport in db2f1ac.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.PathStat in 47d7c9e.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.CopyToContainerOptions in fd1d8f3.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/container.StatsResponseReader in 17c3269.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These types were moved to api/types/container in 0a4277a.

This removes the temporary aliases for:

- ThrottlingData
- CPUUsage
- CPUStats
- MemoryStats
- BlkioStatEntry
- BlkioStats
- StorageStats
- NetworkStats
- PidsStats
- Stats
- StatsJSON (moved/renamed to api/types/container.StatsResponse)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/events.ListOptions in b5f15bc.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/registry.SearchOptions in f6cc76c.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added 3 commits July 2, 2024 14:19
It moved to api/types/image.ImportSource in eb675cc.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It moved to api/types/image.LoadResponse in 6c2934f.
This patch removes the temporary alias.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was moved and deprecated in 1fc9236
(4587688 for v27.0). This patch removes the
temporary alias and removes the relocated  api/types/container.ContainerNode
as well as the Node field on the api/types/container.Base struct.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the remove_deprecated_api_types branch from adacd3b to ef356c5 Compare July 2, 2024 12:20
@thaJeztah thaJeztah marked this pull request as ready for review July 2, 2024 12:21
Copy link
Copy Markdown
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; edited with a quick changelog description

@thaJeztah
Copy link
Copy Markdown
Member Author

edited with a quick changelog description

Oh, thanks! I forgot I didn't update that one yet 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API area/go-sdk impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants