builder/builder-next: applySourcePolicies: remove redundant check and vars#48070
Merged
vvoland merged 1 commit intomoby:masterfrom Jul 1, 2024
Merged
builder/builder-next: applySourcePolicies: remove redundant check and vars#48070vvoland merged 1 commit intomoby:masterfrom
vvoland merged 1 commit intomoby:masterfrom
Conversation
… vars - the check for `ok` was redundant as the line above it would return early - the `t` and `ok` variable declaration was redundant, as all variables to the left of the `strings.Cut` were locally scoped variables. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/builder
vvoland
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
okwas redundant as the line above it would return earlytandokvariable declaration was redundant, as all variables to the left of thestrings.Cutwere locally scoped variables.- A picture of a cute animal (not mandatory but encouraged)