api/types/container: reformat to align windows and unix implementations#48013
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jun 17, 2024
Merged
api/types/container: reformat to align windows and unix implementations#48013thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
- Use a switch instead of if/else for readability and to reduce the risk of duplicates in the checks. - Align order between Windows and Linux implementation for easier comparing of differences in the implementation. - Add a check for `IsHost()` in the Windows implementation which would never occur currently, but is implemented. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Change the order of declarations betwen both implementations for easier comparing of differences. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/api
1 task
vvoland
approved these changes
Jun 17, 2024
Member
Author
|
Failure is unrelated; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/types/container: NetworkMode.NetworkName: use switch
the risk of duplicates in the checks.
comparing of differences in the implementation.
IsHost()in the Windows implementation whichwould never occur currently, but is implemented.
api/types/container: NetworkMode align code between Windows and Linux
Change the order of declarations betwen both implementations for easier
comparing of differences.
- A picture of a cute animal (not mandatory but encouraged)