pkg/longpath: deprecate Prefix const, and use early returns in AddPrefix#47996
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jun 17, 2024
Merged
pkg/longpath: deprecate Prefix const, and use early returns in AddPrefix#47996thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Member
Author
|
@laurazard @vvoland ptal 🤗 |
thaJeztah
commented
Jun 17, 2024
This const was exported because it was in use by pkg/symlink. This dependency was removed in a48c6e3, after which this const was only used internally. This patch deprecates the const and introduces a non-exported const to use. There are no known external consumers of this const, so we may skip deprecating it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
pkg_longpath_deprecate_Prefix
branch
from
c1e488e to
48ff86e
Compare
Member
But it looks like the patch deprecates it? I was a little confused 😅 |
vvoland
approved these changes
Jun 17, 2024
Member
Author
😅 sorry poor wording there; I guess I wanted to write; but we could also decide to skip doing a deprecation first. |
thaJeztah
added
impact/deprecation
area/go-sdk
impact/go-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/longpath: deprecate Prefix const
This const was exported because it was in use by pkg/symlink. This
dependency was removed in a48c6e3,
after which this const was only used internally.
This patch deprecates the const and introduces a non-exported const
to use.
There are no known external consumers of this const, so we may skip
deprecating it.
pkg/longpath: AddPrefix: use early returns
- What I did
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)