c8d/push: Fix small whoopsies#47943
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jun 10, 2024
Merged
Conversation
The target variable was already overwritten with the new value. Use the original value instead. Signed-off-by: Paweł Gronowski <[email protected]>
They might still change to "Mounted from" or "Already exists" when containerd updates the status in tracker. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
status/2-code-review
area/images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--platformswitch #47679- What I did
Fixed some small whoopsies made when addressing review comments in the original PR and noticed them while testing the rebased CLI PR 🙈
c8d/push: Fix wrong Originalindex descriptor in aux error
The target variable was already overwritten with the new value. Use the
original value instead.
c8d/progress: Allow updating "Unavailable" ids
They might still change to "Mounted from" or "Already exists" when
containerd updates the status in tracker.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)