Skip to content

Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only)#47840

Merged
thaJeztah merged 2 commits into
moby:masterfrom
vvoland:update-containerd
May 21, 2024
Merged

Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only)#47840
thaJeztah merged 2 commits into
moby:masterfrom
vvoland:update-containerd

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented May 17, 2024

Update the containerd binary that's used in CI and static binaries

Update containerd (static binaries only) to [v1.7.17](https://github.com/containerd/containerd/releases/tag/v1.7.17)

Signed-off-by: Paweł Gronowski [email protected]

@vvoland vvoland force-pushed the update-containerd branch from 70a641b to 4f0cb7d Compare May 17, 2024 09:07
@vvoland vvoland changed the title Dockerfile: update containerd binary to v1.7.16 (static binaries and CI only) Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) May 17, 2024
@thaJeztah
Copy link
Copy Markdown
Member

This one continues to be flaky. Is that actually related to containerd's shange to use blocksize?;

=== Failed
=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:43: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.77s)

@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented May 21, 2024

Yeah I think it's related. That would solve the flakiness of this test, as now the behavior seems to be consistent 😅

EDIT: Oh, that change wasn't a recent one..

@thaJeztah
Copy link
Copy Markdown
Member

Yes, I also went looking, and that change in continuity already was merged a long time ago (v0.1.0 even?), so curious why it starts to fail more often.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants