Skip to content

vendor: github.com/containerd/containerd v1.7.15#47691

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:vendor-master-containerd-v1.7.15
Apr 9, 2024
Merged

vendor: github.com/containerd/containerd v1.7.15#47691
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:vendor-master-containerd-v1.7.15

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Apr 8, 2024

full diff: containerd/containerd@v1.7.14...v1.7.15

Signed-off-by: Paweł Gronowski [email protected]

containerd image store: OCI archives produced by `docker save` will now have a non-empty `mediaType` field in `index.json` 

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

does the archive change affect what we export?

@vvoland
Copy link
Contributor Author

vvoland commented Apr 9, 2024

Yes, the index.json in docker save archive (with containerd integration) will now have the media type set.

@thaJeztah
Copy link
Member

Do we need a change-log description for that? (just in case?)

@vvoland
Copy link
Contributor Author

vvoland commented Apr 9, 2024

Added a changelog (definitely won't hurt!)

cc @dvdksn

@vvoland vvoland requested a review from thaJeztah April 9, 2024 09:23
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@thaJeztah
Copy link
Member

thaJeztah commented Apr 9, 2024

Interesting; looks like leaving a comment (review) re-triggered the validate-pr / check-area-label check?

Screenshot 2024-04-09 at 12 07 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants