api/image/list: Add container-count parameter#47501
Closed
vvoland wants to merge 1 commit intomoby:masterfrom
Closed
api/image/list: Add container-count parameter#47501vvoland wants to merge 1 commit intomoby:masterfrom
container-count parameter#47501vvoland wants to merge 1 commit intomoby:masterfrom
Conversation
vvoland
added
area/api
Member
|
This looks to be similar to #43350 - do we have a use-case for this, or should we consider going the other direction (make sure we properly define types for each purpose). ISTR some of the |
Contributor
Author
|
We don't have an usage yet, I was mostly just fiddling around the multi-platform |
neersighted
approved these changes
Mar 5, 2024
thaJeztah
requested changes
Mar 5, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
I want to have a closer look before we commit to this; leaving a quick "request changes"
vvoland
commented
Apr 5, 2024
| } | ||
|
|
||
| var containerCount bool | ||
| if versions.GreaterThanOrEqualTo(version, "1.45") { |
vvoland
force-pushed
the
image-list-containers
branch
2 times, most recently
from
c86efff to
793df46
Compare
This parameter was already supported for some time in the backend (for purposes related to `docker system prune`). It was also already present in the `imagetypes.ListOptions` but was never actually handled by the client. This commits makes the client respect the `ContainerCount` and set the form field when sending the request. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
image-list-containers
branch
from
793df46 to
b022c16
Compare
Contributor
Author
|
Opened a related PR: #48345 |
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shared-sizeparameter for images queries #42531opts.ContainerCountfor manifest containers #48345opts.ContainerCountfor manifest containers #48345This parameter was already supported for some time in the backend (for purposes related to
docker system prune).It was also already present in the
imagetypes.ListOptionsbut was never actually handled by the client.This makes the client respect the
ContainerCountand set the form field when sending the request.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)