ci/actions/go-setup: Use vendor.sum as go.sum#47428
Closed
vvoland wants to merge 1 commit intomoby:masterfrom
Closed
ci/actions/go-setup: Use vendor.sum as go.sum#47428vvoland wants to merge 1 commit intomoby:masterfrom
vendor.sum as go.sum#47428vvoland wants to merge 1 commit intomoby:masterfrom
Conversation
actions/go-setup tries to restore the go cache, but expects to read the `go.sum` which we don't have: ``` Run actions/setup-go@v5 ... Found in cache @ /opt/hostedtoolcache/go/1.21.7/x64 ... /opt/hostedtoolcache/go/1.21.7/x64/bin/go env GOMODCACHE /opt/hostedtoolcache/go/1.21.7/x64/bin/go env GOCACHE /home/runner/go/pkg/mod /home/runner/.cache/go-build Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/moby/moby. Supported file pattern: go.sum ``` Make it use `vendor.sum` instead. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
kind/enhancement
Member
|
Do we know what it's trying to restore? Given that we use vendoring, I'm wondering what module cache it would try to use outside of that. If there's none, perhaps we need to disable the cache 🤔 |
Contributor
Author
|
It also restores the go build cache ( |
Contributor
Author
|
I don't see any meaningful impact on the jobs execution time though. So maybe we can just disable that.. |
Member
|
Heh; just had this PR open in my browser; wondering if we should indeed go for disabling the cache to reduce some noise (or did we do so already?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/go-setup tries to restore the go cache, but expects to read the
go.sumwhich we don't have:Make it use
vendor.suminstead.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)