Run the macvlan/ipvlan integration tests#47382
Conversation
|
Ugh. Nice catch 😓 😅 Wondering if (as a follow-up) we should remove the extra indirect of the closure, and make the signature of those subtests less error-prone, e.g. something like; func testIpvlanSubinterface(t *testing.T, ctx context.Context, client dclient.APIClient) { |
Sure - can do ... I'll add another commit to this PR, it might kick the flaky test into working. |
|
Yeah, I like the minimal changes if we want to backport this, but for "master" at least (I think) changing the signature may make it less error prone (that's just at a quick glance though, so take pinches of salt if you don't agree!) |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
for others; the diff is mostly whitespace, and much easier to review with whitespace changes removed; add ?w=1 to the "changes" URL for that; https://github.com/moby/moby/pull/47382/files?w=1
The problem was accidentally introduced in: e8dc902 Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
run_macvlan_ipvlan_tests
branch
from
7a74158 to
9faf485
Compare
3 participants
- What I did
While looking at #47318, I wondered why the change hadn't caused test
TestDockerNetworkMacvlan/OverlapParentto fail...The macvlan/ipvlan tests haven't been running since a hiccup in #45652.
- How I did it
Call the test functions.
- How to verify it
Tests now run.
- Description for the changelog
Fixed integration tests for ipvlan/macvlan.