libnetwork/d/overlay: drop unused miss flags from peerAdd#47234
Merged
akerouanton merged 2 commits intomoby:masterfrom Jan 29, 2024
Merged
libnetwork/d/overlay: drop unused miss flags from peerAdd#47234akerouanton merged 2 commits intomoby:masterfrom
miss flags from peerAdd#47234akerouanton merged 2 commits intomoby:masterfrom
Conversation
as all callers unconditionally set them to false. Signed-off-by: Cory Snider <[email protected]>
as all callers unconditionally set them to false. Signed-off-by: Cory Snider <[email protected]>
corhere
added
area/networking
robmry
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The
l2Missandl3Missboolean arguments tofunc (*driver) peerAddandpeerAddOpwere only used with Serf-based clustering, which has been removed. All callers now unconditionally pass false for both flags. Propagate the constants and drop the arguments.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)