[24.0 backport] pkg/ioutils: Make subsequent Close attempts noop#47221
Merged
[24.0 backport] pkg/ioutils: Make subsequent Close attempts noop#47221
Conversation
Turn subsequent `Close` calls into a no-op and produce a warning with an optional stack trace (if debug mode is enabled). Signed-off-by: Paweł Gronowski <[email protected]> (cherry picked from commit 585d74b) Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
pkg-pools-close-noop-24
branch
from
a869129 to
2918d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn subsequent
Closecalls into a no-op and produce a warning with an optional stack trace (if debug mode is enabled).Signed-off-by: Paweł Gronowski [email protected]
(cherry picked from commit 585d74b)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)