cmd/dockerd: newRouterOptions: pass cluster as argument, and slight cleanup#47188
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 26, 2024
Merged
Conversation
thaJeztah
added
status/2-code-review
area/daemon
thaJeztah
force-pushed
the
cleanup_newRouterOptions
branch
from
c979dcd to
e323e8c
Compare
…leanup - pass the cluster as an argument instead of manually setting it after creating the router-options - remove the "opts" variable, to prevent it accidentally being used (with the assumption that's the value returned) - use a struct-literal for the returned options. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
cleanup_newRouterOptions
branch
from
e323e8c to
c25773e
Compare
Member
Author
|
@laurazard @rumpl ptal |
vvoland
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)