integration-cli: adjust inspect tests to use current API version#47154
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 22, 2024
Merged
integration-cli: adjust inspect tests to use current API version#47154thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
…version This test was added in f301c57 to test inspect output for API > v1.21, however, it was pinned to API v1.21, which is now deprecated. Remove the fixed version, as the intent was to test "current" API versions (API v1.21 and up), Signed-off-by: Sebastiaan van Stijn <[email protected]>
This test was added in f301c57 to test inspect output for API > v1.21, however, it was pinned to API v1.21, which is now deprecated. Remove the fixed version, as the intent was to test "current" API versions (API v1.21 and up), Signed-off-by: Sebastiaan van Stijn <[email protected]>
3 tasks
rumpl
reviewed
Jan 22, 2024
| assert.Assert(c, len(settings.IPAddress) != 0) | ||
| } | ||
|
|
||
| // Inspect for API v1.21 and up; see |
Member
There was a problem hiding this comment.
Does this comment make any sense at all now that we don’t do anything soecial with the api version?
Member
Author
There was a problem hiding this comment.
Honestly, I didn't want to go through the "disable integration-cli check -> merge -> re-enable" cycle to rename the test (removing 121), and thought I'd leave some crumble-patch to why it was named like this 😂
Member
There was a problem hiding this comment.
Oh, was on my phone, didn't see the test name
Member
Author
There was a problem hiding this comment.
No worries; it's a good question, and perhaps it's "too much info". I also anticipated that perhaps we'd have version-dependent changes again in future (but likely we should rewrite / move this test to integration then).
rumpl
approved these changes
Jan 22, 2024
laurazard
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-cli: TestInspectAPIBridgeNetworkSettings121: use current version
This test was added in f301c57 to test
inspect output for API > v1.21, however, it was pinned to API v1.21,
which is now deprecated.
Remove the fixed version, as the intent was to test "current" API versions
(API v1.21 and up),
integration-cli: TestInspectAPIMultipleNetworks: use current version
This test was added in f301c57 to test
inspect output for API > v1.21, however, it was pinned to API v1.21,
which is now deprecated.
Remove the fixed version, as the intent was to test "current" API versions
(API v1.21 and up),
- A picture of a cute animal (not mandatory but encouraged)