Skip to content

api/types: remove deprecated type-aliases#47148

Merged
thaJeztah merged 5 commits intomoby:masterfrom
thaJeztah:api_remove_deprecated_types
Jan 24, 2024
Merged

api/types: remove deprecated type-aliases#47148
thaJeztah merged 5 commits intomoby:masterfrom
thaJeztah:api_remove_deprecated_types

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 21, 2024

relates to:

api/types: remove deprecated system info types and functions

These types were deprecated in c90229e
(v25.0), and moved to api/types/system.

This patch removes the aliases for;

  • api/types.Info
  • api/types.Commit
  • api/types.PluginsInfo
  • api/types.NetworkAddressPool
  • api/types.Runtime
  • api/types.SecurityOpt
  • api/types.KeyValue
  • api/types.DecodeSecurityOptions

api/types: remove deprecated checkpoint-types

These types were deprecated in b688af2
(v25.0), and moved to api/types/checkpoint.

This patch removes the aliases for;

  • api/types.CheckpointCreateOptions
  • api/types.CheckpointListOptions
  • api/types.CheckpointDeleteOptions
  • api/types.Checkpoint

api/types: remove deprecated image-types

These types were deprecated in 48cacbc
(v25.0), and moved to api/types/image.

This patch removes the aliases for;

  • api/types.ImageDeleteResponseItem
  • api/types.ImageSummary
  • api/types.ImageMetadata

api/types: remove deprecated service-types

These types were deprecated in v25.0, and moved to api/types/swarm;

This patch removes the aliases for;

  • api/types.ServiceUpdateResponse (deprecated in 5b3e655)
  • api/types.ServiceCreateResponse (deprecated in ec69501)

api/types: remove deprecated container-types

These types were deprecated in v25.0, and moved to api/types/container;

This patch removes the aliases for;

  • api/types.ResizeOptions (deprecated in 95b92b1)
  • api/types.ContainerAttachOptions (deprecated in 30f09b4)
  • api/types.ContainerCommitOptions (deprecated in 9498d89)
  • api/types.ContainerRemoveOptions (deprecated in 0f77875)
  • api/types.ContainerStartOptions (deprecated in 7bce33e)
  • api/types.ContainerListOptions (deprecated in 9670d93)
  • api/types.ContainerLogsOptions (deprecated in ebef4ef)

- Description for the changelog

Remove deprecated aliases from the api/types package. These types were deprecated
in v25.0.0, which provided temporary aliases. These aliases are now removed:

- api/types.Info
- api/types.Commit
- api/types.PluginsInfo
- api/types.NetworkAddressPool
- api/types.Runtime
- api/types.SecurityOpt
- api/types.KeyValue
- api/types.DecodeSecurityOptions
- api/types.CheckpointCreateOptions
- api/types.CheckpointListOptions
- api/types.CheckpointDeleteOptions
- api/types.Checkpoint
- api/types.ImageDeleteResponseItem
- api/types.ImageSummary
- api/types.ImageMetadata
- api/types.ServiceUpdateResponse
- api/types.ServiceCreateResponse
- api/types.ResizeOptions
- api/types.ContainerAttachOptions
- api/types.ContainerCommitOptions
- api/types.ContainerRemoveOptions
- api/types.ContainerStartOptions
- api/types.ContainerListOptions
- api/types.ContainerLogsOptions

- A picture of a cute animal (not mandatory but encouraged)

These types were deprecated in c90229e
(v25.0), and moved to api/types/system.

This patch removes the aliases for;

- api/types.Info
- api/types.Commit
- api/types.PluginsInfo
- api/types.NetworkAddressPool
- api/types.Runtime
- api/types.SecurityOpt
- api/types.KeyValue
- api/types.DecodeSecurityOptions

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These types were deprecated in b688af2
(v25.0), and moved to api/types/checkpoint.

This patch removes the aliases for;

- api/types.CheckpointCreateOptions
- api/types.CheckpointListOptions
- api/types.CheckpointDeleteOptions
- api/types.Checkpoint

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These types were deprecated in 48cacbc
(v25.0), and moved to api/types/image.

This patch removes the aliases for;

- api/types.ImageDeleteResponseItem
- api/types.ImageSummary
- api/types.ImageMetadata

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These types were deprecated in v25.0, and moved to api/types/swarm;

This patch removes the aliases for;

- api/types.ServiceUpdateResponse (deprecated in 5b3e655)
- api/types.ServiceCreateResponse (deprecated in ec69501)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These types were deprecated in v25.0, and moved to api/types/container;

This patch removes the aliases for;

- api/types.ResizeOptions (deprecated in 95b92b1)
- api/types.ContainerAttachOptions (deprecated in 30f09b4)
- api/types.ContainerCommitOptions (deprecated in 9498d89)
- api/types.ContainerRemoveOptions (deprecated in 0f77875)
- api/types.ContainerStartOptions (deprecated in 7bce33e)
- api/types.ContainerListOptions (deprecated in 9670d93)
- api/types.ContainerLogsOptions (deprecated in ebef4ef)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the api_remove_deprecated_types branch from e0f52ee to 13f4694 Compare January 24, 2024 00:27
@thaJeztah thaJeztah marked this pull request as ready for review January 24, 2024 00:27
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@thaJeztah thaJeztah merged commit 43ffb1e into moby:master Jan 24, 2024
@thaJeztah thaJeztah deleted the api_remove_deprecated_types branch January 24, 2024 11:40
StevenMaude added a commit to cantabular/hanoverd that referenced this pull request May 20, 2024
cipherboy added a commit to cipherboy/openbao that referenced this pull request Nov 14, 2024
This follows churn caused by Docker removing type aliases in use by
others.

See also: moby/moby#47148

Signed-off-by: Alexander Scheel <[email protected]>
cipherboy added a commit to cipherboy/openbao that referenced this pull request Nov 14, 2024
This follows churn caused by Docker removing type aliases in use by
others.

See also: moby/moby#47148

Signed-off-by: Alexander Scheel <[email protected]>
cipherboy added a commit to openbao/openbao that referenced this pull request Nov 14, 2024
* Fully upgrade Docker dependency

This follows churn caused by Docker removing type aliases in use by
others.

See also: moby/moby#47148

Signed-off-by: Alexander Scheel <[email protected]>

* Remove support for Solaris builds

Solaris has no support in upstream Moby any more; while we currently
only test with Docker, we may wish to support containerized plugins
running on remote hosts in the future and would be unable to do so from
Solaris.

Additionally, this release target sees few downloads and thus isn't
worth maintainer time to support.

See also: moby/moby#35373
See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao

Signed-off-by: Alexander Scheel <[email protected]>

* Add changelog entry

Signed-off-by: Alexander Scheel <[email protected]>

---------

Signed-off-by: Alexander Scheel <[email protected]>
Nerkho pushed a commit to Nerkho/openbao that referenced this pull request Feb 26, 2025
* Fully upgrade Docker dependency

This follows churn caused by Docker removing type aliases in use by
others.

See also: moby/moby#47148

Signed-off-by: Alexander Scheel <[email protected]>

* Remove support for Solaris builds

Solaris has no support in upstream Moby any more; while we currently
only test with Docker, we may wish to support containerized plugins
running on remote hosts in the future and would be unable to do so from
Solaris.

Additionally, this release target sees few downloads and thus isn't
worth maintainer time to support.

See also: moby/moby#35373
See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao

Signed-off-by: Alexander Scheel <[email protected]>

* Add changelog entry

Signed-off-by: Alexander Scheel <[email protected]>

---------

Signed-off-by: Alexander Scheel <[email protected]>
bpradipt added a commit to bpradipt/cloud-api-adaptor that referenced this pull request Aug 21, 2025
api/types ContainerListOptions is moved to api/types/container

Ref: moby/moby#47148

Signed-off-by: Pradipta Banerjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants