Skip to content

pkg/homedir: remove deprecated Key() and GetShortcutString()#47130

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:pkg_homedir_deprecated
Jan 22, 2024
Merged

pkg/homedir: remove deprecated Key() and GetShortcutString()#47130
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:pkg_homedir_deprecated

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

These were deprecated in ddd9665 (v25.0), and 3c1de2e, and are no longer used.

- Description for the changelog

- pkg/homedir: remove deprecated Key() and GetShortcutString()

- A picture of a cute animal (not mandatory but encouraged)

These were deprecated in ddd9665 (v25.0),
and 3c1de2e, and are no longer used.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 20, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah
Copy link
Copy Markdown
Member Author

Flaky test; #47119

=== Failed
=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.69s)

@AkihiroSuda AkihiroSuda merged commit 5ad5334 into moby:master Jan 22, 2024
@thaJeztah thaJeztah deleted the pkg_homedir_deprecated branch January 22, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants