Skip to content

pkg/system: remove deprecated ErrNotSupportedOperatingSystem, IsOSSupported#47129

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:pkg_system_deprecated
Jan 22, 2024
Merged

pkg/system: remove deprecated ErrNotSupportedOperatingSystem, IsOSSupported#47129
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:pkg_system_deprecated

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 20, 2024

These were deprecated in a3c97be (v25.0.0), and are no longer used.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- pkg/system: remove deprecated `ErrNotSupportedOperatingSystem`, `IsOSSupported`

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
pkg/system: remove deprecated ErrNotSupportedOperatingSystem, IsOSSup…
f16a217 
…ported

These were deprecated in a3c97be (v25.0.0),
and are no longer used.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 20, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 20, 2024

Flaky test; #47119

=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.64s)

@AkihiroSuda AkihiroSuda merged commit 570b8a7 into moby:master Jan 22, 2024
@thaJeztah thaJeztah deleted the pkg_system_deprecated branch January 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@thaJeztah thaJeztah

Labels

impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Milestone

26.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @AkihiroSuda