Skip to content

remove deprecated pkg/loopback (utility package for devicemapper)#47128

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:remove_pkg_loopback
Jan 22, 2024
Merged

remove deprecated pkg/loopback (utility package for devicemapper)#47128
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:remove_pkg_loopback

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 19, 2024

relates to:

This package was introduced in af59752 as a utility package for devicemapper, which was removed in commit dc11d2a (v25.0.0), and the package was deprecated in bf692d4.

This patch removes the package.

- Description for the changelog

- Removed the deprecated `github.com/docker/docker/pkg/loopback` package.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
remove deprecated pkg/loopback (utility package for devicemapper)
e2086b9 
This package was introduced in af59752
as a utility package for devicemapper, which was removed in commit
dc11d2a (v25.0.0), and the package
was deprecated in bf692d4.

This patch removes the package.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 19, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 20, 2024

Failure on rootless is a known flaky #47119

=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.70s)

@AkihiroSuda AkihiroSuda merged commit 8528ed3 into moby:master Jan 22, 2024
@thaJeztah thaJeztah deleted the remove_pkg_loopback branch January 22, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@thaJeztah thaJeztah

Labels

area/storage/devicemapper impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Milestone

26.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @AkihiroSuda